Skip to content

Add pheno004 example dataset #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2025
Merged

Add pheno004 example dataset #483

merged 4 commits into from
Feb 21, 2025

Conversation

@ericearl
Copy link
Contributor

@ericearl ericearl commented Feb 13, 2025

Meant for the resolution of bids-spec PR 2044. This is a dataset containing a mismatch of subjects with MRI data and tabular phenotypic data to be considered a whole dataset of participants for the sake of the participants.tsv file.

@ericearl
Add pheno004 example dataset
31c5ae7 
Meant for the resolution of bids-spec PR 2044.
@ericearl ericearl requested a review from effigies February 13, 2025 18:54
@ericearl ericearl added effort: low Estimated low effort task bids-validator requires interaction with bids-validator labels Feb 13, 2025
@ericearl ericearl requested a review from rwblair February 13, 2025 18:54
@ericearl ericearl mentioned this pull request Feb 13, 2025
Merged
effigies
effigies approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Once bids-standard/bids-specification#2044 is merged and the schema incorporated into the dev validator, we can revert the BIDS_SCHEMA and merge this.

effigies
effigies reviewed Feb 21, 2025
View reviewed changes
@effigies effigies merged commit 789cc7a into bids-standard:master Feb 21, 2025
13 checks passed
@Remi-Gau
Copy link
Contributor

Remi-Gau commented Mar 3, 2025

this is leading top some failures on the bids website

https://readthedocs.org/projects/bids-website/builds/27369885/

python data/datasets/examples/tools/print_dataset_listing.py docs/datasets/examples.md
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/bids-website/checkouts/629/data/datasets/examples/tools/print_dataset_listing.py", line 185, in <module>
    main()
  File "/home/docs/checkouts/readthedocs.org/user_builds/bids-website/checkouts/629/data/datasets/examples/tools/print_dataset_listing.py", line 65, in main
    check_missing_folders(df, root)
  File "/home/docs/checkouts/readthedocs.org/user_builds/bids-website/checkouts/629/data/datasets/examples/tools/print_dataset_listing.py", line 85, in check_missing_folders
    raise ValueError(
ValueError: Found 84 folders but 83 datasets in the table:missing {'pheno004'} folders

will fix and add a check to avoid this to be detected too late

This was referenced Mar 3, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@effigies effigies effigies approved these changes

@rwblair rwblair Awaiting requested review from rwblair

Assignees

No one assigned

Labels

bids-validator requires interaction with bids-validator effort: low Estimated low effort task enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericearl @Remi-Gau @effigies